fix: Update looped status of entity even if no variables changed#1616
Merged
Conversation
We previously only added a non-looped entity to affected entities if one of its declarative variables changed. However, if null is a valid value (such as for unassigned entities), then it might be the case the looped status of an entity changed from looped to non-looped. We now add an entity to the affected entities list if its loop status changed.
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
approved these changes
May 27, 2025
triceo
left a comment
triceo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this must have been painful to track down!
I've left some comments, but mostly stating the obvious, nothing to be done now.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously only added a non-looped entity to affected entities if one of its declarative variables changed. However, if null is a valid value (such as for unassigned entities), then it might be the case the looped status of an entity changed from looped to non-looped. We now add an entity to the affected entities list if its loop status changed.